Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Ruby version in generated app #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove Ruby version in generated app #22

wants to merge 2 commits into from

Conversation

murugan-r
Copy link
Contributor

@murugan-r
Copy link
Contributor Author

@raghubetina Could you please take a look at it.

raghubetina
raghubetina reviewed Jul 16, 2018
View reviewed changes
template.rb
@@ -234,6 +234,11 @@ def render_file(filename)
# Set up dotenv
file ".env.development", render_file(".env.development")

create_file ".gitignore" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this change? Does it relate to the ruby version?

Copy link
Contributor Author

@murugan-r murugan-r Aug 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raghubetina
Yes. Since in latest rails .gitignore is not included.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? I still get one:

testgitignore HEAD % ls -a
.             .gitignore    Gemfile.lock  app           config.ru     log           storage       vendor
..            .ruby-version README.md     bin           db            package.json  test
.git          Gemfile       Rakefile      config        lib           public        tmp
testgitignore HEAD % rails -v
Rails 5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghubetina raghubetina raghubetina left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murugan-r @raghubetina